This repository was archived by the owner on Jan 10, 2023. It is now read-only.
dumpstate: remote bug reports fail#1
Open
xiangj5x wants to merge 1 commit intoprojectceladon:masterfrom
Open
Conversation
|
Commit message is verified for commit id: e141ed7 |
Call DevicePolicyManager.requestBugreport() in device owner,
the service 'bugreport' killed by signal 1.
This process exit in below code in dumpstate.cpp because the value of do_zip_file is false when is_remote_mode
is true.
if (is_remote_mode && (ds.update_progress_ || !do_broadcast || !do_zip_file || !do_add_date)) {
ExitOnInvalidArgs();
}
before android 8.0,the remotebugreport is designed as below:
service bugreportremote /system/bin/dumpstate -d -q -B -R -z \
-o /data/user_de/0/com.android.shell/files/bugreports/remote/bugreport
but have changed using extra_options_ == "bugreportremote" for distinguish from android 8.0,
miss -z(do_zip_file) premeter when call remotebugreport.
Jira: None
Test: Call DevicePolicyManager.requestBugreport() in device owner,and get reports success.
Signed-off-by: xiangj5x <xiangjunx.jiang@intel.com>
lchen43
approved these changes
May 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call DevicePolicyManager.requestBugreport() in device owner,
the service 'bugreport' killed by signal 1.
Jira: None
Test: Call DevicePolicyManager.requestBugreport() in device owner,and get reports success.
Signed-off-by: xiangj5x xiangjunx.jiang@intel.com